fix(acp): require explicit workspace contract - #4076
Closed
kenyip wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Jarvis <jarvis@kxyip.com>
kenyip
commented
Aug 1, 2026
kenyip
left a comment
kenyip
left a comment
Author
There was a problem hiding this comment.
Jarvis quality gate (estate control-plane): GREEN on de88c5eaafb774fb59e0a94536beae1611d4b9bf.
Reviewed the diff for Host ACP workspace correctness:
- Removes silent
cwd → /fallback on normal startup andmodels resolve_workspace_rootfail-closed: absolute, exists, directory, non-root,AGENTS.md, canonicalize; no root fallback on cwd failure- Validated root is the exact
session/new/ pool cwd; startup summary exposesworkspace= - Setup-listener path skips workspace validation (no ACP session) — preserves desktop setup from
/tmp - Package-scoped verification claimed green (fmt, clippy -D warnings, full
buzz-acptests); DCO/zizmor green on this head
Origin: Buzz #infra multi-agent Build 0. Host-edge mitigations already live on our fleet; harness merge is the correctness ship. Not requesting self-merge; needs upstream review.
Author
|
Closed per Ken (#infra): public PR under personal kenyip opened without explicit gate. Live Host ACP already hardened locally; upstream not required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BUZZ_ACP_WORKSPACE/--workspace-rootcontract for the ACP harnessAGENTS.md-bearingsession/new.cwdinstead of silently substituting/Origin: Buzz
#infrachannelb4547fd2-961e-4b2a-8c8c-04f8ca904c65, thread818196b6b3d07356ff80266e75dc97e8f4f40a963348d332be02c682f8549371.Verification
cargo fmt --all -- --check— passcargo clippy -p buzz-acp --all-targets -- -D warnings— passcargo test -p buzz-acp— pass: 670 unit + 9 integration/fails closedsession/new.cwd/tmpwithoutAGENTS.mdreaches relay connection rather than failing workspace validationKnown environment gap
Full-repo
just cipassed workspace Clippy and desktop JavaScript checks, then stopped in desktop Tauri Clippy because this Linux host lacks GTK/GObject development headers. This is host-only and outside thebuzz-acpharness slice; package fmt, warning-free Clippy, and the completebuzz-acppackage test suite are green.